Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing settings does not work in health extension #4289

Closed
frbuceta opened this issue Dec 11, 2019 · 3 comments
Closed

Changing settings does not work in health extension #4289

frbuceta opened this issue Dec 11, 2019 · 3 comments

Comments

@frbuceta
Copy link
Contributor

Steps to reproduce

When trying to change the settings in health extension, it doesn't work

this.configure(HealthBindings.COMPONENT).to({
  healthPath: '/status',
  livePath: '/status/live',
  readyPath: '/status/ready',
});

Additional information

darwin x64 13.3.0

├── @loopback/authentication@3.2.4
├── @loopback/boot@1.6.0
├── @loopback/context@1.25.0
├── @loopback/core@1.12.0
├── @loopback/extension-health@0.2.13
├── @loopback/openapi-v3@1.10.3
├── @loopback/repository@1.16.0
├── @loopback/rest@1.25.0
├── @loopback/rest-explorer@1.4.6
├── @loopback/security@0.1.9
├── @loopback/service-proxy@1.3.13
└── loopback-connector-mssql@3.6.0

Related Issues

See Reporting Issues for more tips on writing good issues

@frbuceta frbuceta added the bug label Dec 11, 2019
@raymondfeng
Copy link
Contributor

Does /status give 404?

You have to call this.configure before this.component(HealthComponent) due to a limitation that can be fixed.

We have an acceptance test to cover such config. See https://github.com/strongloop/loopback-next/blob/master/extensions/health/src/__tests__/acceptance/health.acceptance.ts#L117-L127.

@frbuceta
Copy link
Contributor Author

frbuceta commented Dec 11, 2019

Does /status give 404?

Yes, it returns me a 404

You have to call this.configure before this.component(HealthComponent) due to a limitation that can be fixed.

Works!!!

@dhmlau
Copy link
Member

dhmlau commented Feb 25, 2020

Closing as resolved.

@dhmlau dhmlau closed this as completed Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants