New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(extension-health): add function call-order note #4410
docs(extension-health): add function call-order note #4410
Conversation
06c8366
to
8e74834
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note:
this.configure()
must be called beforethis.component()
to prevent a
404 HTTP error. This is a
known issue.
I don't like the causality of '404 HTTP error'. Maybe just write:
"Note: this.configure()
has to be called before this.component()
to take effekt."
8e74834
to
ec015b3
Compare
@derdeka Thanks for the suggestion, I've made the changes. Please let me know if there's any other issues. |
Just wondering would a blue note be better to add emphasis?:
|
Signed-off-by: Rifa Achrinza <25147899+achrinza@users.noreply.github.com> docs(extension-health): add function call-order note Signed-off-by: Rifa Achrinza <25147899+achrinza@users.noreply.github.com> docs(extension-health): add function call-order note Signed-off-by: Rifa Achrinza <25147899+achrinza@users.noreply.github.com> docs(extension-health): add function call-order note Signed-off-by: Rifa Achrinza <25147899+achrinza@users.noreply.github.com>
ec015b3
to
752b1de
Compare
Signed-off-by: Rifa Achrinza 25147899+achrinza@users.noreply.github.com
See also #4289
Adds a notice to inform users of the mandatory function calling order of
this.component()
andthis.configure()
to prevent a 404 HTTP error.Checklist
馃憠 Read and sign the CLA (Contributor License Agreement) 馃憟
npm test
passes on your machinepackages/cli
were updatedexamples/*
were updated馃憠 Check out how to submit a PR 馃憟