Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use NeDB to replace our own memory connector #49

Closed
superkhau opened this issue Feb 14, 2017 · 3 comments
Closed

Use NeDB to replace our own memory connector #49

superkhau opened this issue Feb 14, 2017 · 3 comments
Assignees
Labels

Comments

@superkhau
Copy link
Contributor

https://github.com/louischatriot/nedb

@raymondfeng Thoughts?

@superkhau
Copy link
Contributor Author

@bajtos Thoughts too?

@bajtos
Copy link
Member

bajtos commented Feb 16, 2017

I don't mind either way. Here are two questions to consider:

  • Will the complexity of writing nedb connector outweigh the cost of maintaining our existing memory connector?
  • I personally find _id property a big ugly. IIRC, MongoDB has the same issue and we are somehow converting _id to id in our convertor. I guess we can do the same with nedb, but it's another extra complexity to take into our consideration.

@superkhau
Copy link
Contributor Author

I'm going to close this as maintaining our own gives us more control, like Context for example. Will reopen if necessary to reduce issue count.

raymondfeng pushed a commit that referenced this issue Oct 23, 2018
Use `@class` value as the name (header)
raymondfeng pushed a commit that referenced this issue Oct 24, 2018
Use `@class` value as the name (header)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants