fix(sequelize): parse JSON columns to objects for mysql dialect #10285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 8590810023Details
💛 - Coveralls |
KalleV
force-pushed
the
KalleV-fix-json-data-types-mysql
branch
from
98a5a9d
to
8a3c326
Compare
KalleV
changed the title
KalleV
commented
Jan 9, 2024
extensions/sequelize/src/__tests__/integration/repository.integration.ts
Outdated
Show resolved
Hide resolved
samarpanB
requested changes
Feb 12, 2024
samarpanB
approved these changes
Mar 27, 2024
|
@KalleV This PR is good to be merged now. Can you please rebase this PR ? |
Signed-off-by: KalleV <kvirtaneva@gmail.com>
Signed-off-by: KalleV <kvirtaneva@gmail.com>
Signed-off-by: KalleV <kvirtaneva@gmail.com>
Signed-off-by: KalleV <kvirtaneva@gmail.com>
Signed-off-by: KalleV <kvirtaneva@gmail.com> chore: merge conflicts Signed-off-by: KalleV <kvirtaneva@gmail.com> chore: refactor type import Signed-off-by: KalleV <kvirtaneva@gmail.com> chore: skip db2 in parseJsonColumn test Signed-off-by: KalleV <kvirtaneva@gmail.com> chore: fix test case Signed-off-by: KalleV <kvirtaneva@gmail.com> chore: empty commit for CI Signed-off-by: KalleV <kvirtaneva@gmail.com>
KalleV
force-pushed
the
KalleV-fix-json-data-types-mysql
branch
from
e7317a4
to
bf20d64
Compare
|
@samarpanB Thanks! I fixed the rebase merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By parsing the values to JSON objects, provide backward compatibility for JSON and Array entity properties when using dialects like MySQL, MariaDB, or SQLite.
Fixes: #9629
Fixes: #9598
Checklist
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈