Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add script to build typescript project references #1636

Closed
wants to merge 2 commits into from
Closed

chore: add script to build typescript project references #1636

wants to merge 2 commits into from

Commits on Jun 3, 2019

  1. feat: enable declarationMap, use .d.ts files in monorepo too 

    Configure TSC to emit declaration maps, providing information needed by
IDEs like VSCode to jump from usage of a symbol to its definition in
the original source code.

Simplify layout of all packages, remove top-level `index.ts` and
`index.d.ts` files in favor of a package.json entry

    "types": "dist/index.d.ts"

Simplify layout of module packages (excluding example applications) and
remove the top-level `index.js` file in favor of a package.json entry
    "main": "dist/index.js"

Update developer documentation and project templates accordingly.

Benefits of these changes:

- It's a preparation step for TypeScript Project References

- Build is consuming less CPU cycles now. User time used to be 5m21
  before, it's 1m48s now. Real time went down from 0m49s to 0m37s.

- Simpler project setup in our packages, we no longer need to maintain
  dummy index files at the top level.

Drawbacks:

- Refactor-rename does not work across packagas. I believe this is a
  limitation of TypeScript, hopefully it will be eventually fixed.

- Navigation across packages may not work until the monorepo is built.
    @bajtos @raymondfeng
    bajtos authored and raymondfeng committed Jun 3, 2019
    Configuration menu
    Copy the full SHA
    96b1871 View commit details
    Browse the repository at this point in the history

  2. feat: enable support for typescript references 

    - add script to build typescript project references
- reorg project layout for better typescript refs
- switch to tsconfig.json
- add copy-resources script
    @raymondfeng
    raymondfeng committed Jun 3, 2019
    Configuration menu
    Copy the full SHA
    9bb6296 View commit details
    Browse the repository at this point in the history