Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(testlab): set port to zero in givenHttpServerConfig #1738

Merged
merged 1 commit into from
Sep 21, 2018

Conversation

bajtos
Copy link
Member

@bajtos bajtos commented Sep 21, 2018

Modify the test helper givenHttpServerConfig to explicitly set the port to zero. With this change in place, applications can use this helper in acceptation tests without having to explicitly specify {port: 0} to override RestServer's default port 3000.

Checklist

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

Modify the test helper `givenHttpServerConfig` to explicitly set
the port to zero. With this change in place, applications can use
this helper in acceptation tests without having to explicitly
specify `{port: 0}` to override RestServer's default port 3000.
@bajtos bajtos self-assigned this Sep 21, 2018
@bajtos bajtos changed the title feat(testlab): set port to 0 in givenHttpServerConfig feat(testlab): set port to zero in givenHttpServerConfig Sep 21, 2018
@bajtos
Copy link
Member Author

bajtos commented Sep 21, 2018

AppVeyor's failure is unrelated to these changes.

123 1) build
124       generates apidocs:
125     Error: Timeout of 30000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (C:\projects\loopback-next\packages\build\test\integration\scripts.integration.js)
126  
127
128
129
130

@bajtos bajtos merged commit 90a0bfb into master Sep 21, 2018
@bajtos bajtos deleted the feat/default-to-port0-in-tests branch September 21, 2018 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants