feat: refactor auth action #2746
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jannyHou
commented
Apr 12, 2019
.vscode/settings.json
Outdated
| @@ -1,5 +1,7 @@ | |||
| { | |||
| "editor.rulers": [80], | |||
| "editor.rulers": [ | |||
| 80 | |||
bajtos
reviewed
Apr 15, 2019
packages/authentication/src/types.ts
Outdated
|
|
||
| export interface AuthenticationStrategy { | ||
| name: string; | ||
| isPassportStrategy?: boolean; |
There was a problem hiding this comment.
-1
AFAIK, passport strategies use different API contract than LB4 AuthenticationStrategy. IMO, we should tell people to use StrategyAdapter to convert Passport strategies into LB strategies.
There was a problem hiding this comment.
@bajtos yeah that flag is added at the wrong place, see my comment 53cfeeb#r33223459 .
jannyHou
force-pushed
the
auth-action
branch
2 times, most recently
from
792a108
to
53cfeeb
Compare
emonddr
force-pushed
the
dremond_authentication_2312
branch
2 times, most recently
from
cddb4ea
to
6a196cf
Compare
Resolve authentication strategies registered via extension point
emonddr
force-pushed
the
dremond_authentication_2312
branch
from
53f74bd
to
0c022bb
Compare
jannyHou
force-pushed
the
auth-action
branch
2 times, most recently
from
b727dff
to
92b10a2
Compare
Resolve authentication strategies registered via extension point
Add tests for registered jwt authentication strategy. And fixup some copyright comments.
removed duplicate interface definitions
moved acceptance artifacts to fixtures folder
Move authentication action and strategy providers into main code
emonddr
force-pushed
the
dremond_authentication_2312
branch
3 times, most recently
from
45f1fd4
to
bcf041e
Compare
emonddr
force-pushed
the
dremond_authentication_2312
branch
from
6096b8b
to
f016ff5
Compare
7 tasks
emonddr
force-pushed
the
dremond_authentication_2312
branch
2 times, most recently
from
d484f7f
to
519e0d1
Compare
emonddr
force-pushed
the
dremond_authentication_2312
branch
3 times, most recently
from
42eb051
to
5e2ab05
Compare
|
Close this one in favor of #2822 |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
connect to #2467
This PR starts to refactor the authentication action to takes in a getter for the newly created AuthenticationStrategy interface in #2688.
StrategyAdapteris also refactored to implement theAuthenticationStrategyinterfaceChecklist
馃憠 Read and sign the CLA (Contributor License Agreement) 馃憟
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated馃憠 Check out how to submit a PR 馃憟