feat(testlab): add generic helper skipOnTravis
#3040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bajtos
force-pushed
the
feat/generic-skip-on-travis
branch
from
cd73ca5
to
ab16360
Compare
raymondfeng
reviewed
Jun 4, 2019
| * implementing the test. | ||
| */ | ||
| export function skipOnTravis<ARGS extends unknown[], RETVAL>( | ||
| verb: TestDefinition<ARGS, RETVAL> & {skip: TestDefinition<ARGS, RETVAL>}, |
There was a problem hiding this comment.
Can we make verb default to it?
There was a problem hiding this comment.
I prefer not to. Without the verb, it would be difficult to understand whether we are defining a test case (it()) or a test suite (describe()) or something else (context()).
skipOnTravis('returns some value when some conditions', async () => {
// the test
});
raymondfeng
approved these changes
Jun 4, 2019
Introduce a generic helper `skipOnTravis` that supports arbitrary BDD verbs (`it`, `describe`, etc.) in a test-framework-agnostic way. Rework `itSkippedOnTravis` to leverage the new helper and deprecate it (in tsdocs only). Signed-off-by: Miroslav Bajto拧 <mbajtoss@gmail.com>
bajtos
force-pushed
the
feat/generic-skip-on-travis
branch
from
ab16360
to
392e850
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a generic helper
skipOnTravisthat supports arbitrary BDD verbs (it,describe, etc.) in a test-framework-agnostic way. ReworkitSkippedOnTravisto leverage the new helper and deprecate it (in tsdocs only).This is a follow-up for #3013.
Checklist
馃憠 Read and sign the CLA (Contributor License Agreement) 馃憟
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated馃憠 Check out how to submit a PR 馃憟