refactor(repository): simplify ensurePromise helper
#3149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loopback-datasource-juggler is always using native Promises, no need to wrap the promises returned by juggler APIs into another Promise instance. Signed-off-by: Miroslav Bajto拧 <mbajtoss@gmail.com>
bajtos
force-pushed
the
refactor/simplify-promise-check
branch
from
758c4e5
to
57403bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
loopback-datasource-juggler is always using native Promises, no need to wrap the promises returned by juggler APIs into another Promise instance.
This is a follow-up for loopbackio/loopback-datasource-juggler#1749 and older loopbackio/loopback-datasource-juggler#1631.
I discovered this improvement opportunity while experimenting with optimizing dependencies of
@loopback/repository(loosely related to #3126).Checklist
馃憠 Read and sign the CLA (Contributor License Agreement) 馃憟
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated馃憠 Check out how to submit a PR 馃憟