Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: document listenOnStart for REST servers #3891

Merged
merged 1 commit into from
Oct 7, 2019

Conversation

raymondfeng
Copy link
Contributor

@raymondfeng raymondfeng commented Oct 7, 2019

Document the feature introduced by #3879

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

@dhmlau dhmlau added the Docs label Oct 7, 2019
// Run the application
const config = {
rest: {
port: +process.env.PORT || 3000,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

an extra +?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, + prefix converts the string into number.

@raymondfeng raymondfeng merged commit 819a660 into master Oct 7, 2019
@raymondfeng raymondfeng deleted the listen-on-start-docs branch October 7, 2019 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants