Add missing exclude in root package.json #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superkhau
force-pushed
the
bug/add-missing-exclude-in-root-packagejson
branch
from
44d1f95
to
ef82a62
Compare
|
@superkhau huh, I believe this have disabled tslint checks for all files. What was the purpose of this change? |
3 tasks
Merged
|
Fixed in #86 |
ritch
added a commit
that referenced
this pull request
Mar 3, 2017
* Fix codehub spec * WIP Versioning Feature for CodeHub * Health Feature for CodeHub * Updated CodeHub with HealthController and app.start() * Fix missing statusCode property in LoopBack test (#84) * Fix missing exclude in root package.json (#83) * Add VS Code tasks to run CodeHub tests (#82) * Revert "Fix missing exclude in root package.json" * This reverts commit 9c4d857. * Revert "Fix missing statusCode property..." * This reverts commit 282eb7d. * Add missing `@types/request` dependency * Make routing acceptance test closer to real usage * Disable default exports (#89) * Fixups based on review * Fix feature template in example-codehub * Update entry point to app instead of server * Additions * Implemented json header (hardcoded) * Fix linting errors * Move main to index (codehub)
ritch
added a commit
that referenced
this pull request
Mar 3, 2017
* Add first redirect feature to CodeHub * Fix codehub spec * WIP Versioning Feature for CodeHub * Health Feature for CodeHub * Updated CodeHub with HealthController and app.start() * Fix missing statusCode property in LoopBack test (#84) * Fix missing exclude in root package.json (#83) * Add VS Code tasks to run CodeHub tests (#82) * Revert "Fix missing exclude in root package.json" * This reverts commit 9c4d857. * Revert "Fix missing statusCode property..." * This reverts commit 282eb7d. * Add missing `@types/request` dependency * Make routing acceptance test closer to real usage * Disable default exports (#89) * Fixups based on review * Fix feature template in example-codehub * Update entry point to app instead of server * Additions * Implemented json header (hardcoded) * Fix linting errors * Move main to index (codehub) * Code review fixups * Fix missing json assertion for health test (codehub) * Copyright header fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @bajtos @raymondfeng @ritch