Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update polyglot dependency to point to v2 major version #172

Conversation

SuperManifolds
Copy link
Contributor

Description

Polyglot had to be moved to a v2 subfolder structure for compatibility reasons, this updates frisbee's dependency paths accordingly
Requires loopholelabs/polyglot#42 to be merged and released

Fixes # (issue)

Type of change

[x] Refactor

Final Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have signed-off my commits with git commit -s (see the developer's certificate of origin)

Copy link
Member

@ShivanshVij ShivanshVij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SuperManifolds SuperManifolds merged commit da667d4 into staging Apr 23, 2024
5 checks passed
@SuperManifolds SuperManifolds deleted the alex/frpc-19-update-polyglot-dependencies-to-fix-versioning branch April 23, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants