Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alex/frpc 19 update polyglot dependencies to fix versioning #42

Conversation

SuperManifolds
Copy link
Contributor

Description

Recent versions of Polyglot needs to be in a new major version to avoid breaking backwards compatibility for projects like Scale that depends on the previous API for interacting with buffers. This restructures the project so the new version since the major performance refactor last year is in /v2

Fixes Issue FRPC-19

Type of change

  • Refactor (non-breaking change which does not add functionality) [title: 'refactor:']

Final Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have signed-off my commits with git commit -s (see the developer's certificate of origin)

Copy link
Member

@ShivanshVij ShivanshVij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SuperManifolds SuperManifolds merged commit 1b318fb into staging Apr 23, 2024
9 checks passed
@SuperManifolds SuperManifolds deleted the alex/frpc-19-update-polyglot-dependencies-to-fix-versioning branch April 23, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants