Update filter operation.

loophp · Jul 22, 2020 · 8374728 · 8374728
1 parent b65cffe
commit 8374728
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/spec/loophp/collection/CollectionSpec.php b/spec/loophp/collection/CollectionSpec.php
@@ -590,8 +590,11 @@ static function ($value) {
                     return mb_strlen($value) - 1 === mb_strpos($value, 'o');
                 }
             )
-            ->normalize()
-            ->shouldIterateAs(['allo']);
+            ->shouldIterateAs([2 => 'allo']);
+
+        $this::fromIterable([true, false, 0, '', null])
+            ->filter()
+            ->shouldIterateAs([true]);
     }
 
     public function it_can_flatten(): void

diff --git a/src/Operation/Filter.php b/src/Operation/Filter.php
@@ -14,7 +14,13 @@ final class Filter extends AbstractOperation implements Operation
 {
     public function __construct(callable ...$callbacks)
     {
-        $this->storage['callbacks'] = $callbacks;
+        $defaultCallback = static function ($item): bool {
+            return true === (bool) $item;
+        };
+
+        $this->storage['callbacks'] = [] === $callbacks ?
+            [$defaultCallback] :
+            $callbacks;
     }
 
     public function __invoke(): Closure