Add When operation. #105
Add When operation. #105
Conversation
|
At first glance I can't tell what's the difference between this and |
This operation operates on the collection object once, while the |
| * @return \loophp\collection\Collection<TKey, T> | ||
| */ | ||
| public function when(callable $predicate, callable $whenTrue, ?callable $whenFalse = null): Collection; |
There was a problem hiding this comment.
should this return Collection the implementation or Collection the contract?
Isn't there a mismatch here? the @return is showing the implementation, but the actual return type of the function is the contract
I understand now, thanks for clarifying this in the docs! 🙌 |
|
@drupol do you mind adding the static analysis check with any new operation please? This ensures we get the types right on the user side 😁 |
|
True ! I have to get used to that, will do that later in the day for sure. |
This PR