Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Operation Interfaces return Collection Interface #108

Merged
merged 1 commit into from
Jun 13, 2021
Merged

Operation Interfaces return Collection Interface #108

merged 1 commit into from
Jun 13, 2021

Conversation

AlexandruGG
Copy link
Collaborator

This PR corrects the return type on Operation Contracts (Interfaces), which return the Collection Contract (Interface), not the Collection class implementation

@AlexandruGG
Copy link
Collaborator Author

@drupol I'm surprised that analysers didn't complain about the mismatch between the @return annotation and the actual return type 🤷‍♂️

@AlexandruGG AlexandruGG marked this pull request as ready for review June 13, 2021 21:22
drupol
drupol approved these changes Jun 13, 2021
View reviewed changes
Copy link
Collaborator

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good here!

@drupol drupol merged commit facd4a4 into loophp:master Jun 13, 2021
@drupol
Copy link
Collaborator

drupol commented Jun 13, 2021

Thanks once again!

@AlexandruGG AlexandruGG deleted the feature/correct-interfaces-return-types branch June 14, 2021 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drupol drupol drupol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AlexandruGG @drupol