Introduce MapN | Deprecate Map With Multiple Callbacks | Static Analysis Checks

[AlexandruGG]

This PR introduces MapN based on the discussions in #77, and deprecates Map usage with multiple callbacks.

• MapN code (same as Map but with more mixed type hints)
• Deprecate Map with multiple callbacks
• Map stays backwards compatible
• Tests
• Static analysis checks
• Documentation

[AlexandruGG]

@drupol hey, let me know if this looks good to you and I will update the documentation as well

[drupol]

Hi Alex,

Thanks for this PR !
I was about to give the approval but then I had an idea.

Instead of throwing the exception in the Operation class Map, why not throwing it from Collection::map() ?
Wouldn't it be better? WDYT?

[AlexandruGG]

Hi Alex,

Thanks for this PR !
I was about to give the approval but then I had an idea.

Instead of throwing the exception in the Operation class Map, why not throwing it from Collection::map() ?
Wouldn't it be better? WDYT?

Hey, thanks for reviewing!

I considered that, however it's not sufficient because the library provides the Operations to be used separately. So someone that will use the operation directly like this also needs to know about the deprecation if used with multiple callbacks. That's why I also had to update this usage to MapN

[drupol]

Hi Alex,
Thanks for this PR !
I was about to give the approval but then I had an idea.
Instead of throwing the exception in the Operation class Map, why not throwing it from Collection::map() ?
Wouldn't it be better? WDYT?

Hey, thanks for reviewing!

I considered that, however it's not sufficient because the library provides the Operations to be used separately. So someone that will use the operation directly like this also needs to know about the deprecation if used with multiple callbacks. That's why I also had to update this usage to MapN

You're perfectly right, that was a bad idea :)

Can't wait to be in version 5 to remove the ugly count() in map!

[AlexandruGG]

@drupol hey, added documentation now and addressed comments, this should be ready 😁

[drupol]

Nothing to add here, all good :)