Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Reverse operation - optimize and remove todos. #138

Merged
merged 4 commits into from
Jul 12, 2021
Merged

Update Reverse operation - optimize and remove todos. #138

merged 4 commits into from
Jul 12, 2021

Conversation

drupol
Copy link
Collaborator

@drupol drupol commented Jul 11, 2021 •
edited

This PR:

  • Fix Reverse operation - optimize and get rid of todos finally !
  • Add static analysis tests

This can use the new Reduce operation (#139) if that PR is merged before.

@drupol drupol requested a review from AlexandruGG July 11, 2021 20:37
@drupol drupol added the enhancement New feature or request label Jul 11, 2021
@drupol drupol self-assigned this Jul 12, 2021
@drupol drupol changed the title Update Reverse operation - optimize and remove todos. Update Reverse operation - optimize and remove todos. Jul 12, 2021
@drupol drupol merged commit 9a76ad2 into master Jul 12, 2021
@drupol drupol deleted the optimize-reverse-operation branch July 12, 2021 11:42
drupol added a commit that referenced this pull request Jul 12, 2021
@drupol
Update Reverse operation - optimize and remove todos. (#138)
d18d2b2 
* refactor: Update Reverse operation - optimize and remove todos.

* Autofix code style.

* tests: Add static analysis tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexandruGG AlexandruGG AlexandruGG approved these changes

Assignees

@drupol drupol

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@drupol @AlexandruGG