Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Span: Add Variadic Callback Support #140

Merged
merged 2 commits into from
Jul 12, 2021
Merged

Span: Add Variadic Callback Support #140

merged 2 commits into from
Jul 12, 2021

Conversation

AlexandruGG
Copy link
Collaborator

This PR:

  • Adds variadic callbacks support to the existing Span operation
  • Has unit tests (phpspec)
  • Has static analysis tests (psalm, phpstan)
  • Has documentation
  • Part of v5 preparations

@AlexandruGG AlexandruGG marked this pull request as ready for review July 12, 2021 11:04
drupol
drupol approved these changes Jul 12, 2021
View reviewed changes
Copy link
Collaborator

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 ! Thanks!

@drupol drupol merged commit 2ea1fe6 into master Jul 12, 2021
@drupol drupol deleted the feature/span-variadic-callbacks branch July 12, 2021 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drupol drupol drupol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AlexandruGG @drupol