Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AsyncMapN Operation | Remove AsyncMap Variadic Callbacks Usage #141

Merged
merged 2 commits into from
Jul 12, 2021
Merged

Add AsyncMapN Operation | Remove AsyncMap Variadic Callbacks Usage #141

merged 2 commits into from
Jul 12, 2021

Conversation

AlexandruGG
Copy link
Collaborator

This PR:

  • Adds the AsyncMapN Operation - similar to MapN
  • Modifies AsyncMap to only accept a single callback
  • It breaks backward compatibility
  • Has unit tests (phpspec)
  • Has static analysis tests (psalm, phpstan)
  • Has documentation

Related to #135.

@AlexandruGG AlexandruGG marked this pull request as ready for review July 12, 2021 17:48
@AlexandruGG
Copy link
Collaborator Author

@drupol this is ready for review :)

@drupol
Copy link
Collaborator

drupol commented Jul 12, 2021

💯 !!! Thanks !!!

@drupol drupol merged commit 296940f into master Jul 12, 2021
@drupol drupol deleted the feature/async-map-n branch July 12, 2021 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AlexandruGG @drupol