refactor: Rename variables and properties. #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexandruGG
reviewed
Jul 15, 2021
| @@ -29,7 +29,7 @@ public function it_allows_array_of_any_type(): void | |||
| { | |||
| $data = [self::MAP_DATA, self::LIST_DATA]; | |||
|
|
|||
| $this->beConstructedWith($data); | |||
| $this->beConstructedWith(new ArrayIterator($data)); | |||
There was a problem hiding this comment.
why do we not want to allow this to be constructed from array?
There was a problem hiding this comment.
- We avoid mixing types.
- I rather use the composition (decorator pattern) like every other iterators.
(cherry picked from commit 5c831ece40ea320308de5f04fd85a5634cc64f22)
drupol
force-pushed
the
refactor/update-variables-names-and-types
branch
from
e527b60
to
a7cfc8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
TypedIterator