Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Reduce the use of the spread operators and variadic parameters #146

Merged
merged 1 commit into from
Jul 16, 2021
Merged

refactor: Reduce the use of the spread operators and variadic parameters #146

merged 1 commit into from
Jul 16, 2021

Conversation

drupol
Copy link
Collaborator

@drupol drupol commented Jul 14, 2021 •
edited

This PR:

  • Reduce the amount of spread operators and variadic parameters (perf improvement)
  • Thanks to this, in the future it will be possible to pass more than 2 parameters to Collection and|or ClosureIterator.
  • It breaks backward compatibility: The constructor of Collection and ClosureIterator has been altered.
  • All tests has been updated

@drupol drupol force-pushed the refactor/reduce-spread-operators-and-variadic-parameters branch 2 times, most recently from c869587 to 36dfcf8 Compare July 16, 2021 09:25
@drupol drupol self-assigned this Jul 16, 2021
@drupol drupol force-pushed the refactor/reduce-spread-operators-and-variadic-parameters branch from 36dfcf8 to c11780b Compare July 16, 2021 11:18
@drupol drupol marked this pull request as ready for review July 16, 2021 11:21
@drupol drupol requested a review from AlexandruGG July 16, 2021 11:22
@drupol drupol force-pushed the refactor/reduce-spread-operators-and-variadic-parameters branch from c11780b to b4430dc Compare July 16, 2021 17:48
@drupol drupol merged commit 9038c00 into master Jul 16, 2021
@drupol drupol deleted the refactor/reduce-spread-operators-and-variadic-parameters branch July 16, 2021 18:33
@AlexandruGG AlexandruGG mentioned this pull request Jul 17, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexandruGG AlexandruGG Awaiting requested review from AlexandruGG

Assignees

@drupol drupol

Labels
backward breaking change enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@drupol