Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ::fromGenerator constructor. #150

Merged
merged 9 commits into from
Jul 26, 2021

Conversation

drupol
Copy link
Collaborator

@drupol drupol commented Jul 17, 2021

This PR:

  • Provide a new Collection::fromGenerator(Generator $generator) constructor.
  • Has unit tests (phpspec)
  • Has static analysis tests (psalm, phpstan)
  • Has documentation

@drupol drupol self-assigned this Jul 17, 2021
@drupol drupol mentioned this pull request Jul 17, 2021
3 tasks
@drupol drupol force-pushed the feature/add-fromGenerator-constructor branch 2 times, most recently from b0a7661 to 463564c Compare July 17, 2021 11:51
@github-actions
Copy link

Since this pull request has not had any activity within the last 5 days, I have marked it as stale.
I will close it if no further activity occurs within the next 5 days.

@github-actions github-actions bot added the stale label Jul 23, 2021
@drupol drupol removed the stale label Jul 23, 2021
@drupol drupol force-pushed the feature/add-fromGenerator-constructor branch from de699dd to 20693c2 Compare July 23, 2021 21:34
@drupol drupol marked this pull request as ready for review July 23, 2021 21:36
docs/pages/api.rst Outdated Show resolved Hide resolved
docs/pages/api.rst Outdated Show resolved Hide resolved
docs/pages/api.rst Outdated Show resolved Hide resolved
docs/pages/api.rst Outdated Show resolved Hide resolved
drupol and others added 4 commits July 25, 2021 07:57
Co-authored-by: Alex Gidei <34811569+AlexandruGG@users.noreply.github.com>
Co-authored-by: Alex Gidei <34811569+AlexandruGG@users.noreply.github.com>
Copy link
Collaborator

@AlexandruGG AlexandruGG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

5hozbx

@drupol drupol merged commit 22ee3fb into master Jul 26, 2021
@drupol drupol deleted the feature/add-fromGenerator-constructor branch July 26, 2021 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants