Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop accepts non-variadic count #157

Merged
merged 2 commits into from
Jul 24, 2021
Merged

Drop accepts non-variadic count #157

merged 2 commits into from
Jul 24, 2021

Conversation

AlexandruGG
Copy link
Collaborator

This PR:

  • Updates Drop so that it only accepts one parameter - the number of items to drop
  • It breaks backward compatibility - will be released in version 5
  • Has unit tests (phpspec)
  • Has static analysis tests (psalm, phpstan)
  • Has documentation

Related to #156 (comment).

@AlexandruGG AlexandruGG marked this pull request as ready for review July 22, 2021 21:38
@AlexandruGG
Copy link
Collaborator Author

@drupol this is ready for review. If you're happy with it just approve but don't merge please, as I might need to solve merge conflicts if #156 gets merged first

drupol
drupol previously approved these changes Jul 22, 2021
Copy link
Collaborator

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks mate :) merge it anytime!

@AlexandruGG
Copy link
Collaborator Author

@drupol this is ready to merge now :). Thanks!

@drupol drupol merged commit c6d5b91 into master Jul 24, 2021
@drupol drupol deleted the feature/drop-non-variadic branch July 24, 2021 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants