Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Update Reject operation #167

Merged
merged 1 commit into from
Aug 1, 2021
Merged

refactor: Update Reject operation #167

merged 1 commit into from
Aug 1, 2021

Conversation

drupol
Copy link
Collaborator

@drupol drupol commented Jul 31, 2021

This PR:

  • Use Filter based algorithm
  • Use point free style.

@drupol drupol added the enhancement New feature or request label Jul 31, 2021
@drupol drupol requested a review from AlexandruGG July 31, 2021 19:09
@drupol drupol enabled auto-merge (squash) July 31, 2021 19:10
@drupol drupol disabled auto-merge July 31, 2021 19:35
@drupol drupol marked this pull request as draft July 31, 2021 19:35
@drupol drupol force-pushed the refactor/update-reject-operation branch from 64463eb to e90fede Compare July 31, 2021 19:36
@drupol drupol marked this pull request as ready for review July 31, 2021 19:36
@drupol drupol force-pushed the refactor/update-reject-operation branch from e90fede to f38f816 Compare July 31, 2021 19:37
@drupol drupol enabled auto-merge (squash) July 31, 2021 19:51
@drupol drupol changed the title Update Reject operation refactor: Update Reject operation Jul 31, 2021
AlexandruGG
AlexandruGG reviewed Aug 1, 2021
View reviewed changes
src/Operation/Reject.php
}
}
};
static function (callable ...$callbacks): Closure {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't tell for sure but does this closure have doc block type hints for the callables?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Filter's callback? If this is it, indeed, I forgot the type hints, I will fix later, after family lunch :)

@drupol drupol merged commit 9cad8ae into master Aug 1, 2021
@drupol drupol deleted the refactor/update-reject-operation branch August 1, 2021 09:04
@AlexandruGG
Copy link
Collaborator

Oops didn't realise this was set for auto-merge 😄

@drupol drupol mentioned this pull request Aug 1, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexandruGG AlexandruGG AlexandruGG approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@drupol @AlexandruGG