refactor: Update cross product operation in point free style.
#177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems that there is an issue with the latest PSalm version (4.9.3)... investigating. |
drupol
changed the title
product operation in point free style
drupol
changed the title
product operation in point free styleproduct operation in point free style.
drupol
force-pushed
the
refactor/update-cross-product-operation
branch
from
f8aa923
to
91535c3
Compare
|
I updated |
AlexandruGG
approved these changes
Aug 18, 2021
There was a problem hiding this comment.
I cannot see the Psalm issue anymore but looks like you sorted it by restricting the version so should be fine for now.
On a separate note, I think this new form is extremely difficult to follow and understand 😅.
What do you think of using some variables just to make it a bit easier to follow? It shouldn't affect performance too much.
For example, storing this closure in a variable. Same for the others, and then combining in the Pipe. Alternatively, we could add comments to show what each one represents?
|
@drupol auto-merge got me again 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Productin point free style.