Static analysis: Update Map operation.
#192
Conversation
| @@ -192,7 +193,7 @@ | |||
| * @template-extends Lastable<TKey, T> | |||
| * @template-extends Limitable<TKey, T> | |||
| * @template-extends Linesable<TKey, T> | |||
| * @template-extends Mapable<TKey, T> | |||
| * @template-extends Mapable<TKey, T, V> | |||
There was a problem hiding this comment.
seeing the errors on this I'm thinking it's not the right way.
Looking at the Doctrine ArrayCollection the template variable is defined on the method.
I played with the Psalm example a bit more and came up with another version which works while keeping the template param at the same level:
https://psalm.dev/r/e840743851
https://phpstan.org/r/5166ee20-1783-4d1d-93f6-91e4ac3570b4
Note the callback is passed from the invoke method. I think the issue with the initial one might be that the template is defined at a different level from where the callback is passed, so it "can't know" the return type of the callback. This is just my assumption, I can't claim to understand this fully 😄
There was a problem hiding this comment.
Going to analyze this later in the day for sure!
There was a problem hiding this comment.
Voila, I updated the top message with the relevant PSalm snippets.
I'm still searching for the best way to implement this.
|
Since this pull request has not had any activity within the last 5 days, I have marked it as stale. |
|
Since this pull request has not had any activity within the last 5 days, I have marked it as stale. |
|
Since this pull request has not had any activity within the last 5 days, I have marked it as stale. |
|
Since this pull request has not had any activity within the last 5 days, I have marked it as stale. |
This PR:
MapoperationPsalm snippets:
In the end, I'm here (https://psalm.dev/r/33088712ff), there's only one issue remaining.
I asked @weirdan and he proposed:
I'm still experimenting on the best way to fix this issue.