refactor: Fix PSalm issues. #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexandruGG
reviewed
Sep 11, 2021
| first_checkIntElement(Collection::fromIterable([1, 2, 3])->first()->current()); | ||
| /** @psalm-suppress PossiblyNullArgument @phpstan-ignore-next-line */ | ||
| /** @psalm-suppress NullArgument @phpstan-ignore-next-line */ |
There was a problem hiding this comment.
this might be problematic I think if Psalm always thinks that these are null. I tried debugging a bit:
INFO: Trace - tests/static-analysis/last.php:59:1 - $var: loophp\collection\Contract\Collection<0|1|2, 1|2|3>&loophp\collection\Contract\Collection (see https://psalm.dev/224)
/** @psalm-trace $var */
$var = Collection::fromIterable([1, 2, 3])->first();
Psalm now sees first() as creating an intersection type for some reason and I think that's why when applying current() after it resolves the type to null.
I tried to replicate somewhat in the playground but couldn't :( https://psalm.dev/r/609938fcc6
There was a problem hiding this comment.
I think there is an issue and we should let the PSalm team know about it.
There was a problem hiding this comment.
I will open an issue and see where we get, if it's a legitimate thing or not
There was a problem hiding this comment.
@drupol opened an issue here, let's see what they think: vimeo/psalm#6685
AlexandruGG
approved these changes
Sep 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
I'm definitely unsure about this thing, @AlexandruGG WDYT?