Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix All operation for standalone usage #215

Merged
merged 1 commit into from
Nov 7, 2021
Merged

Fix All operation for standalone usage #215

merged 1 commit into from
Nov 7, 2021

Conversation

AlexandruGG
Copy link
Collaborator

This PR:

  • Fixes usage of the All as standalone with Pipe
  • Has documentation

Follows #209 (comment). Every operation needs to return an Iterator in order to be pipeable.

drupol
drupol approved these changes Nov 7, 2021
View reviewed changes
Copy link
Collaborator

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested and reviewed, all good.

@AlexandruGG AlexandruGG merged commit 8a7852e into master Nov 7, 2021
@AlexandruGG AlexandruGG deleted the feature/fix-all-standalone-operation branch November 7, 2021 17:11
@drupol
Copy link
Collaborator

drupol commented Nov 7, 2021

Thanks again :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drupol drupol drupol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AlexandruGG @drupol