Fix reducing operations
#288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexandruGG
previously approved these changes
Dec 28, 2022
drupol
force-pushed
the
fix/reduce-operations
branch
2 times, most recently
from
c722b9b
to
f804ac9
Compare
drupol
force-pushed
the
fix/reduce-operations
branch
from
f804ac9
to
4cea3e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
reduce,reduction,scanLeft,scanRightNote, the psalm issues are related to the upgrade to 5.4, they will be fixed in a follow up PR which is almost done.
Follows a discussion on Mastodon with @azjezz at https://mathstodon.xyz/@Pol/109588243184619262