Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implements stable sorting #333

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Conversation

drupol
Copy link
Collaborator

@drupol drupol commented Jan 15, 2024

Fix #331

This PR:

Copy link

what-the-diff bot commented Jan 15, 2024

PR Summary

  • Enabling Automatic Loading for New Directory
    The team has included one more directory named "fixture" to the autoload-dev section in our composer.json file. This is designed to automatically load certain classes during development for smoother workflow.

  • Updated Documentation For Sorting Behavior
    They have added a new paragraph in our API documentation (api.rst) discussing the updated default behavior of data sorting starting from version 7.4. This provides our users with clear and up-to-date instructions on this functionality.

  • Enhanced Sorting Functionality
    A modification has been made to our Sort.php file which improves our data sorting functionality. We can now support stable sorting, which maintains the relative order of items with equal sort keys. This should ensure that data remain in their original order even after being sorted.

  • New File for Testing
    A new file MyValueObject.php has been added to the tests/fixtures directory. This object will aid in creating test scenarios and making sure everything runs as expected.

  • Added Test Method for Sorting
    A new test method named testIssue331 has been added to our IssuesTest.php file. This test specifically checks the functionality of our new sorting feature utilizing the MyValueObject class. It helps ensure the sorting function runs smoothly and as expected.

@drupol drupol force-pushed the feat/implements-stable-sorting branch from 9981e6e to 4219c36 Compare January 15, 2024 11:07
@drupol drupol force-pushed the feat/implements-stable-sorting branch from 4219c36 to bfe6a55 Compare January 15, 2024 12:51
@drupol drupol merged commit 267dabe into master Jan 15, 2024
15 checks passed
@drupol drupol deleted the feat/implements-stable-sorting branch January 15, 2024 13:10
@drupol drupol mentioned this pull request Jan 19, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request] Implement stable sorting
1 participant