New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ScanLeft so it doesn't go further if the iterator is not valid #49

Merged

drupol merged 1 commit into master from 48-implode-refactoring

Dec 8, 2020

Collaborator

drupol commented Dec 8, 2020

This PR

Fixes implode() would be better if it returned null/'' on empty array. #48
Has a small behavior change that will be documented


          fix: Update ScanLeft so it doesn't go further if the iterator is not …

5d9e448

…valid.

Collaborator Author

drupol commented Dec 8, 2020

Merging this despite the unrelated CS issue (PHP-CS-Fixer/PHP-CS-Fixer#4435 (comment)).

drupol merged commit ceea8f1 into master

drupol deleted the 48-implode-refactoring branch

December 8, 2020 17:44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment