refactor: Do not make unit assertions in benchmarks.

loophp · Jan 5, 2022 · 8117ebb · 8117ebb
1 parent aedcb38
commit 8117ebb
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 74 deletions.
diff --git a/tests/benchmarks/CachingIteratorsAggregateBench.php b/tests/benchmarks/CachingIteratorsAggregateBench.php
@@ -9,7 +9,6 @@
 
 namespace benchmarks\loophp\iterators;
 
-use Exception;
 use Generator;
 use loophp\iterators\CachingIteratorAggregate;
 use loophp\iterators\SimpleCachingIteratorAggregate;
@@ -19,7 +18,6 @@
 use PhpBench\Benchmark\Metadata\Annotations\Warmup;
 use Psl\Iter\Iterator as IterIterator;
 use Traversable;
-use function count;
 
 /**
  * @Groups({"CachingIteratorsAggregateBench"})
@@ -80,27 +78,6 @@ private function loop(Traversable $input, int $breakAt): Generator
 
     private function test(Traversable $input, int $size): void
     {
-        $breakAt = $size / 2;
-
-        $a = iterator_to_array($this->loop($input, $breakAt));
-        $b = iterator_to_array($this->loop($input, $breakAt));
-        $c = iterator_to_array($this->loop($input, $breakAt));
-        $d = iterator_to_array($this->loop($input, $breakAt));
-
-        if (count($a) !== $size) {
-            throw new Exception('$a !== $size => Invalid benchmark.');
-        }
-
-        if ($a !== $b) {
-            throw new Exception('$a !== $b => Invalid benchmark.');
-        }
-
-        if ($b !== $c) {
-            throw new Exception('$b !== $c => Invalid benchmark.');
-        }
-
-        if ($c !== $d) {
-            throw new Exception('$c !== $d => Invalid benchmark.');
-        }
+        iterator_to_array($this->loop($input, $size / 2));
     }
 }
diff --git a/tests/benchmarks/PackIterableAggregateBench.php b/tests/benchmarks/PackIterableAggregateBench.php
@@ -9,15 +9,13 @@
 
 namespace benchmarks\loophp\iterators;
 
-use Exception;
 use Generator;
 use loophp\iterators\PackIterableAggregate;
 use PhpBench\Benchmark\Metadata\Annotations\Groups;
 use PhpBench\Benchmark\Metadata\Annotations\Iterations;
 use PhpBench\Benchmark\Metadata\Annotations\Revs;
 use PhpBench\Benchmark\Metadata\Annotations\Warmup;
 use Traversable;
-use function count;
 
 /**
  * @Groups({"internal"})
@@ -64,10 +62,6 @@ private function loop(Traversable $input): Generator
 
     private function test(Traversable $input, int $size): void
     {
-        $a = iterator_to_array($this->loop($input));
-
-        if (count($a) !== $size) {
-            throw new Exception('$a !== $size => Invalid benchmark.');
-        }
+        iterator_to_array($this->loop($input));
     }
 }
diff --git a/tests/benchmarks/RandomIterableAggregateBench.php b/tests/benchmarks/RandomIterableAggregateBench.php
@@ -9,15 +9,13 @@
 
 namespace benchmarks\loophp\iterators;
 
-use Exception;
 use Generator;
 use loophp\iterators\RandomIterableAggregate;
 use PhpBench\Benchmark\Metadata\Annotations\Groups;
 use PhpBench\Benchmark\Metadata\Annotations\Iterations;
 use PhpBench\Benchmark\Metadata\Annotations\Revs;
 use PhpBench\Benchmark\Metadata\Annotations\Warmup;
 use Traversable;
-use function count;
 
 /**
  * @Groups({"internal"})
@@ -64,10 +62,6 @@ private function loop(Traversable $input): Generator
 
     private function test(Traversable $input, int $size): void
     {
-        $a = iterator_to_array($this->loop($input));
-
-        if (count($a) !== $size) {
-            throw new Exception('$a !== $size => Invalid benchmark.');
-        }
+        iterator_to_array($this->loop($input));
     }
 }
diff --git a/tests/benchmarks/SimpleCachingIteratorsAggregateBench.php b/tests/benchmarks/SimpleCachingIteratorsAggregateBench.php
@@ -9,15 +9,13 @@
 
 namespace benchmarks\loophp\iterators;
 
-use Exception;
 use Generator;
 use loophp\iterators\SimpleCachingIteratorAggregate;
 use PhpBench\Benchmark\Metadata\Annotations\Groups;
 use PhpBench\Benchmark\Metadata\Annotations\Iterations;
 use PhpBench\Benchmark\Metadata\Annotations\Revs;
 use PhpBench\Benchmark\Metadata\Annotations\Warmup;
 use Traversable;
-use function count;
 
 /**
  * @Groups({"internal"})
@@ -45,7 +43,7 @@ public function benchIterator(array $params): void
 
     public function provideGenerators(): Generator
     {
-        $items = 25000;
+        $items = 5000;
 
         yield SimpleCachingIteratorAggregate::class => [
             'class' => SimpleCachingIteratorAggregate::class,
@@ -68,27 +66,6 @@ private function loop(Traversable $input, int $breakAt): Generator
 
     private function test(Traversable $input, int $size): void
     {
-        $breakAt = $size / 2;
-
-        $a = iterator_to_array($this->loop($input, $breakAt));
-        $b = iterator_to_array($this->loop($input, $breakAt));
-        $c = iterator_to_array($this->loop($input, $breakAt));
-        $d = iterator_to_array($this->loop($input, $breakAt));
-
-        if (count($a) !== $size) {
-            throw new Exception('$a !== $size => Invalid benchmark.');
-        }
-
-        if ($a !== $b) {
-            throw new Exception('$a !== $b => Invalid benchmark.');
-        }
-
-        if ($b !== $c) {
-            throw new Exception('$b !== $c => Invalid benchmark.');
-        }
-
-        if ($c !== $d) {
-            throw new Exception('$c !== $d => Invalid benchmark.');
-        }
+        iterator_to_array($this->loop($input, $size / 2));
     }
 }
diff --git a/tests/benchmarks/UnpackIterableAggregateBench.php b/tests/benchmarks/UnpackIterableAggregateBench.php
@@ -9,15 +9,13 @@
 
 namespace benchmarks\loophp\iterators;
 
-use Exception;
 use Generator;
 use loophp\iterators\UnpackIterableAggregate;
 use PhpBench\Benchmark\Metadata\Annotations\Groups;
 use PhpBench\Benchmark\Metadata\Annotations\Iterations;
 use PhpBench\Benchmark\Metadata\Annotations\Revs;
 use PhpBench\Benchmark\Metadata\Annotations\Warmup;
 use Traversable;
-use function count;
 
 /**
  * @Groups({"internal"})
@@ -64,10 +62,6 @@ private function loop(Traversable $input): Generator
 
     private function test(Traversable $input, int $size): void
     {
-        $a = iterator_to_array($this->loop($input));
-
-        if (count($a) !== $size) {
-            throw new Exception('$a !== $size => Invalid benchmark.');
-        }
+        iterator_to_array($this->loop($input));
     }
 }
diff --git a/tests/unit/ClosureIteratorTest.php b/tests/unit/ClosureIteratorTest.php
@@ -41,15 +41,17 @@ public function testRewind(): void
     {
         $iterator = new ClosureIterator(
             static fn (array $iterable): array => $iterable,
-            [self::MAP_DATA]
+            [range('a', 'e')]
         );
 
-        self::assertSame(1, $iterator->current());
+        self::assertSame('a', $iterator->current());
         $iterator->next();
-        self::assertSame(2, $iterator->current());
+        self::assertSame('b', $iterator->current());
+        $iterator->next();
+        self::assertSame('c', $iterator->current());
 
         $iterator->rewind();
 
-        self::assertSame(1, $iterator->current());
+        self::assertSame('a', $iterator->current());
     }
 }