Update code on GraphViz exporter based on Scrutinizer analysis.

loophp · Jun 26, 2019 · 4c23013 · 4c23013
1 parent 9938e31
commit 4c23013
Showing 1 changed file with 23 additions and 22 deletions.
diff --git a/src/Exporter/Gv.php b/src/Exporter/Gv.php
@@ -32,28 +32,29 @@ class Gv implements ExporterInterface
      */
     public function export(NodeInterface $node): string
     {
-        $attributes = [];
-        foreach ($this->attributes as $key => $attribute) {
-            if (\is_string($attribute)) {
-                $attributes[] = \sprintf(
-                    '  %s = %s',
-                    $key,
-                    $attribute
-                );
-
-                continue;
-            }
-
-            if (\is_array($attribute)) {
-                $attributes[] = \sprintf(
-                    '  %s %s',
-                    $key,
-                    $this->attributesArrayToText($attribute)
-                );
-
-                continue;
-            }
-        }
+        $attributes = \array_map(
+            function ($key, $data) {
+                if (\is_string($data)) {
+                    return \sprintf(
+                        '  %s = %s',
+                        $key,
+                        $data
+                    );
+                }
+
+                if (\is_array($data)) {
+                    return \sprintf(
+                        '  %s %s',
+                        $key,
+                        $this->attributesArrayToText($data)
+                    );
+                }
+
+                return null;
+            },
+            \array_keys($this->attributes),
+            $this->attributes
+        );
 
         $nodes = [];
         foreach ($node->all() as $child) {