Optimizations.

loophp · Jan 9, 2019 · 94eea79 · 94eea79
1 parent fc5dbcc
commit 94eea79
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 9 deletions.
diff --git a/src/Exporter/Graph.php b/src/Exporter/Graph.php
@@ -5,7 +5,7 @@
 namespace drupol\phptree\Exporter;
 
 use drupol\phptree\Node\NodeInterface;
-use drupol\phptree\Traverser\BreadthFirst;
+use drupol\phptree\Traverser\PreOrder;
 use drupol\phptree\Traverser\TraverserInterface;
 use Fhaculty\Graph\Graph as OriginalGraph;
 use Fhaculty\Graph\Vertex;
@@ -38,7 +38,7 @@ class Graph implements ExporterInterface
     public function __construct(OriginalGraph $graph = null, TraverserInterface $traverser = null)
     {
         $this->graph = $graph ?? new OriginalGraph();
-        $this->traverser = $traverser ?? new BreadthFirst();
+        $this->traverser = $traverser ?? new PreOrder();
     }
 
     /**

diff --git a/src/Modifier/Reverse.php b/src/Modifier/Reverse.php
@@ -22,12 +22,8 @@ public function modify(NodeInterface $tree): NodeInterface
             $children->append($this->modify($child));
         }
 
-        $newTree = $tree->withChildren();
-
-        for ($i = $children->count()-1; $i >= 0; $i--) {
-            $newTree->add($children[$i]);
-        }
-
-        return $newTree;
+        return $tree->withChildren(...\array_reverse(
+            $children->getArrayCopy()
+        ));
     }
 }