Fix code-style and tests.

loophp · Jun 26, 2019 · d9ba43e · d9ba43e
1 parent 9940b9a
commit d9ba43e
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 8 deletions.
diff --git a/spec/drupol/phptree/Exporter/GvSpec.php b/spec/drupol/phptree/Exporter/GvSpec.php
@@ -56,21 +56,22 @@ public function it_can_export_to_dot_gv()
 
         $result = <<<EOF
 digraph PHPTreeGraph {
-
+// The graph attributes.
   ratio = fill
   node [style="filled"]
 
+// The graph nodes.
   "{$nodes['root']['hash']}" [label="{$nodes['root']['value']}"]
   "{$nodes['child1']['hash']}" [label="{$nodes['child1']['value']}"]
   "{$nodes['child4']['hash']}" [label="{$nodes['child4']['value']}"]
   "{$nodes['child2']['hash']}" [label="{$nodes['child2']['value']}"]
   "{$nodes['child3']['hash']}" [label="{$nodes['child3']['value']}"]
 
+// The graph edges.
   "{$nodes['root']['hash']}" -> "{$nodes['child1']['hash']}";
   "{$nodes['child1']['hash']}" -> "{$nodes['child4']['hash']}";
   "{$nodes['root']['hash']}" -> "{$nodes['child2']['hash']}";
   "{$nodes['root']['hash']}" -> "{$nodes['child3']['hash']}";
-
 }
 EOF;
         $this
@@ -81,21 +82,22 @@ public function it_can_export_to_dot_gv()
 
         $result = <<<EOF
 graph PHPTreeGraph {
-
+// The graph attributes.
   ratio = fill
   node [style="filled"]
 
+// The graph nodes.
   "{$nodes['root']['hash']}" [label="{$nodes['root']['value']}"]
   "{$nodes['child1']['hash']}" [label="{$nodes['child1']['value']}"]
   "{$nodes['child4']['hash']}" [label="{$nodes['child4']['value']}"]
   "{$nodes['child2']['hash']}" [label="{$nodes['child2']['value']}"]
   "{$nodes['child3']['hash']}" [label="{$nodes['child3']['value']}"]
 
+// The graph edges.
   "{$nodes['root']['hash']}" -- "{$nodes['child1']['hash']}";
   "{$nodes['child1']['hash']}" -- "{$nodes['child4']['hash']}";
   "{$nodes['root']['hash']}" -- "{$nodes['child2']['hash']}";
   "{$nodes['root']['hash']}" -- "{$nodes['child3']['hash']}";
-
 }
 EOF;
         $this

diff --git a/src/Exporter/Gv.php b/src/Exporter/Gv.php
@@ -75,9 +75,9 @@ public function export(NodeInterface $node): string
         }
 
         return $this->getGv(
-            implode(PHP_EOL, $attributes),
-            implode(PHP_EOL, $nodes),
-            implode(PHP_EOL, $edges)
+            \implode(PHP_EOL, $attributes),
+            \implode(PHP_EOL, $nodes),
+            \implode(PHP_EOL, $edges)
         );
     }
 

diff --git a/src/Node/TrieNode.php b/src/Node/TrieNode.php
@@ -14,7 +14,7 @@ class TrieNode extends KeyValueNode
      */
     public function add(NodeInterface ...$nodes): NodeInterface
     {
-        /** @var \drupol\phptree\Node\ValueNodeInterface $node */
+        /** @var \drupol\phptree\Node\KeyValueNodeInterface $node */
         foreach ($nodes as $node) {
             $data = $node->getValue();