Fix issue with TrieNode when value is ending with same string.

loophp · Dec 27, 2018 · efd938b · efd938b
1 parent ba0b0b6
commit efd938b
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/spec/drupol/phptree/Node/TrieNodeSpec.php b/spec/drupol/phptree/Node/TrieNodeSpec.php
@@ -20,6 +20,12 @@ public function it_can_add_node()
         $this->beConstructedWith('root', 'root');
 
         $nodes = [
+            1000,
+            1001,
+            10011,
+            2000,
+            2001,
+            20011,
             'ab',
             'abc',
             'abcd',
@@ -31,12 +37,12 @@ public function it_can_add_node()
         ];
 
         foreach ($nodes as $key => $value) {
-            $nodes[$key] = new KeyValueNode($key, $value);
+            $nodes[$key] = new KeyValueNode($key, (string) $value);
         }
 
         $this
             ->add(...$nodes)
             ->count()
-            ->shouldReturn(25);
+            ->shouldReturn(43);
     }
 }
diff --git a/src/Node/TrieNode.php b/src/Node/TrieNode.php
@@ -23,7 +23,7 @@ public function add(NodeInterface ...$nodes): NodeInterface
             $parent = $this->append($node);
 
             $dataWithoutFirstLetter = \substr($data, 1);
-            if (!empty($dataWithoutFirstLetter)) {
+            if ($dataWithoutFirstLetter > '') {
                 $parent->add(new TrieNode($hash, $dataWithoutFirstLetter));
             } else {
                 $nodes = [$node->getValue()];