Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switching to flight mode does not throw exception #323

Closed
subaira opened this issue Oct 11, 2013 · 3 comments
Closed

Switching to flight mode does not throw exception #323

subaira opened this issue Oct 11, 2013 · 3 comments
Assignees
@smarek
Labels
critical feature-request
Milestone
1.4.4

Comments

@subaira
Copy link

subaira commented Oct 11, 2013

I was using this library in my Android project. During testing, when I switched to flight mode while http request was in progress, no exception was thrown by the library.
@yasiralijaved
Copy link

it should be fixed.

@smarek
Copy link
Member

smarek commented Oct 11, 2013

@yasiralijaved you mean it has been fixed already or it should be fixed?

@yasiralijaved
Copy link

@smarek its not fixed yet. it should be fixed. many crashes in app occurred due to this issue. now, i am explicitly handling this "Flight Mode" situation when a HTTP request is under process.

@ghost ghost assigned smarek Oct 13, 2013
@smarek smarek mentioned this issue Oct 14, 2013
Closed
@smarek smarek closed this as completed in e6d72f4 Oct 15, 2013
iNdieboyjeff pushed a commit to iNdieboyjeff/android-async-http that referenced this issue Oct 17, 2013
Merge branch 'master' of https://github.com/loopj/android-async-http
8d20208 
# By Peter Edwards (6) and others
# Via Marek Sebera (2) and others
* 'master' of https://github.com/loopj/android-async-http:
  Undid example change for now
  Classpath change
  Handling delete RequestParams in SyncHttpClient
  Throwing malformed URL fixes android-async-http#115, Throwing Interrupted exception fixes android-async-http#323
  Javadoc for AsyncHttpClient
  Fixes android-async-http#227
  Fixes android-async-http#253
  Allow request params of nested map, list, and set
  change retry handler to call appropriate method
  Fix SyncHttpClient to work with @sweetlilmre refactored code
  Added FileAsyncHttpResponseHandler based on: android-async-http#134
  Big download fixes: Removed unnecessary buffer copy (should allow for larger downloads and helps to combat VM heap constraints) Wrapped allocation in OutOfMemory handler, current behaviour will signal the GC and retry. This _sometimes_ works if GC has a change to run
  Reworked Json handler to parse json on the download thread in the failure case and fixed the messaging to be consistant updated javadocs
  Refactored AsyncHttpResponseHandler.java code base to facilitate a single base class and to use binary as the base response format Refactored dependent AsyncHttpResponseHandler.java classes: BinaryHttpResponseHandler.java, JsonHttpResponseHandler.java Added new ResponseHandler: TextHttpResponseHandler.java Cleaned up exception handling, added missing exception handling and mofified RetryHandler behavior to be more robust Moved handler to separate class to avoid leaks in AsyncHttpRequest.java Added PROGRESS and RETRY messages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smarek smarek

Labels
critical feature-request
Projects
None yet
Milestone
1.4.4
Development

No branches or pull requests
3 participants
@smarek @yasiralijaved @subaira