Skip to content
This repository has been archived by the owner on Jan 26, 2022. It is now read-only.

Fix wrong error when response is empty #100

Merged
merged 1 commit into from Feb 14, 2019

Conversation

mavimo
Copy link
Collaborator

@mavimo mavimo commented Feb 14, 2019

Some API actions will return empty content (eg merge lead) that generate issue on response decoding. This behaviour is changed between php 5.6 and 7.x, so we need to fix id since the current release support 7.x development.

https://3v4l.org/1vZPv
https://3v4l.org/LFme1

@mavimo mavimo self-assigned this Feb 14, 2019
@mavimo mavimo force-pushed the fix-error-with-empty-response branch from 363d9f9 to c84d027 Compare February 14, 2019 19:14
@mavimo mavimo force-pushed the fix-error-with-empty-response branch from c84d027 to b4f84d6 Compare February 14, 2019 19:19
@mavimo mavimo merged commit 0489970 into develop Feb 14, 2019
@mavimo mavimo deleted the fix-error-with-empty-response branch February 14, 2019 19:48
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 18.261% when pulling b4f84d6 on fix-error-with-empty-response into 1059856 on develop.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants