Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ENBSeries #349

Closed
wants to merge 1 commit into from
Closed

Conversation

Superfly-Johnson
Copy link
Contributor

Similarly to the previous PR, ENBSeries is effectively obsolete of rnew vegas. People should use Reshade and more modern plugins instead

@pStyl3
Copy link
Member

pStyl3 commented Sep 29, 2023

The obsolete message advises the user to update to the latest version, so it's not exactly fit for what the intention of this PR is.

That being said, I think that we need to decline this PR, as ENBSeries vs Reshade is not an objective thing - it's subjective and you will find people from both sides thinking that the one or the other is better.

@Superfly-Johnson
Copy link
Contributor Author

ENBSeries conflicts with New Vegas Tick Fix and New Vegas Heap Replacer, both of which are considered essential mods for new vegas. Most of the new vegas community thinks ENBSeries is obsolete and dangerous to use with a modern install

@WilliamImm
Copy link
Member

WilliamImm commented Sep 30, 2023

Suggestion: mark ENBSeries as incompatible with New Vegas Tick Fix and New Vegas Heap Replacer, instead of marking it as obsolete. This should keep the subjectivity of it vs ReShade out and focus on the objectivity, which is that it's incompatible with these mentioned mods.

Most would go and keep Tick Fix and Heap Replacer anyways due to their benefits and modern modding recs anyways.

EDIT: Mind, this should be a new message anchor regardless of what we do.

@Superfly-Johnson
Copy link
Contributor Author

ENBSeries for New Vegas hasn't been updated since 2014 and hasn't ever been completed. It's not a matter of subjective as it would be for Skyrim or SkyrimSE where ENB is both feature complete and stable, it's a matter of it just hasn't kept up with the rest of the modding community and frankly shouldn't be used anymore as better and more specialized mods exist already

@pStyl3
Copy link
Member

pStyl3 commented Oct 1, 2023

If ENBSeries is conflicting with New Vegas Tick Fix and New Vegas Heap Replacer, it is making these mods incompatible to one another - but in my opinion this does not warrant declaring ENBSeries obsolete and a general advise to use Reshade instead.

I think @WilliamImm's idea might be the best approach. Therefore I'm gonna open an issue for that and close this PR without merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants