Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring: Unified Logger class for mods #1556

Closed
4 tasks done
alek13 opened this issue Jul 18, 2024 · 0 comments
Closed
4 tasks done

Refactoring: Unified Logger class for mods #1556

alek13 opened this issue Jul 18, 2024 · 0 comments
Assignees
@alek13
Labels
core refactoring Касающееся крупной переработки имеющейся возможности

Comments

@alek13
Copy link
Member

alek13 commented Jul 18, 2024 •
edited
Loading

  • see mods/lord/Game/lord_web_integration/src/web_integration/Logger.lua
  • add minetest.get_mod_logger()
  • pass into minetest.mod() (add lazy loading logger field into virtual class minetest.Mod)
  • replace in web_integration & clans (extracted into Clans v3: use standard helpers.Logger #1564)
@alek13 alek13 added refactoring Касающееся крупной переработки имеющейся возможности core labels Jul 19, 2024
alek13 added a commit to alek13/lord that referenced this issue Jul 20, 2024
@alek13
Refactoring: add helpers.Logger class. Relates to lord-server#1556
da95427
alek13 added a commit to alek13/lord that referenced this issue Jul 20, 2024
@alek13
Refactoring: add lazy loading field logger into minetest.Mod. Rea…
bea9150 
…lates to lord-server#1556
@alek13 alek13 mentioned this issue Jul 20, 2024
Open
@alek13 alek13 closed this as completed Jul 20, 2024
alek13 added a commit to alek13/lord that referenced this issue Jul 21, 2024
@alek13
Remove forgotten unused code; rename param. Relates lord-server#1556
e7c0359
@alek13 alek13 self-assigned this Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alek13 alek13

Labels
core refactoring Касающееся крупной переработки имеющейся возможности
Projects
Рефакторинг
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alek13