"import Holes as ho" not appropriate

[olgabot]

Hello,
Thank you for putting the effort into making a persistent homology library for python! This looks like a nice package, and I'd like to try it. The name "Holes" is especially cute. I have a suggestion: for the example notebooks, and for future use, instead of import Holes as ho, which is inappropriate for a scientific package, use a different acronym such as import Holes as hl. It's a small change but I think will make a big difference in the adoption of your package.
Thanks,
Olga

[mr-c]

+1

[kghose]

+1. The package name should be changed too. http://www.urbandictionary.com/define.php?term=hole

[olgabot]

I'm not sure if I'd go so far as to change the package name, since "holes"
is relevant to the function - it's finding topological structures and
surfaces that have holes in them. Ultimately, it's up to the authors.

On Sat Jan 31 2015 at 8:40:32 PM Kaushik Ghose notifications@github.com
wrote:

+1. The package name should be changed too.
http://www.urbandictionary.com/define.php?term=hole

—
Reply to this email directly or view it on GitHub
#1 (comment).

[kennethlove]

👍

[lordgrilo]

Hey,
thanks for the suggestion.
It was indeed a bad idea (due to laziness).
The "ho" abbreviation as been changed to "hl" throughout the repository.

[rgbkrk]

👍 thanks @lordgrilo

[olgabot]

thank you!