Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emojis no longer rendered properly in the comments #126

Closed
IndrajeetPatil opened this issue Jan 14, 2024 · 12 comments · Fixed by #127
Closed

Emojis no longer rendered properly in the comments #126

IndrajeetPatil opened this issue Jan 14, 2024 · 12 comments · Fixed by #127

Comments

@IndrajeetPatil
Copy link

E.g. r-lib/styler#1173 (comment)

Screenshot 2024-01-14 at 15 45 15
@assignUser
Copy link
Collaborator

  • ☑️tet

@assignUser
Copy link
Collaborator

hm, maybe some changes to how automatic comments are treated?

@assignUser
Copy link
Collaborator

assignUser commented Jan 14, 2024

Editing around in another comment shows that they are rendered again when the leading html space is removed:

  • ☑️define_data: 15.4ms -> 15.4ms [-2.34%, +1.44%]
  • ☑️dist_beta: 211ms -> 211ms [-5.83%, +5.96%]

@olivroy
Copy link

olivroy commented Mar 28, 2024

Still an issue r-lib/styler#1189 (comment) and in comment above

Probably just needs as space to make it work ?

or maybe styler has not updated its workflows?

image

@lorenzwalthert
Copy link
Owner

Also don’t geht that. Styler seems to use the main tag, so it should use the latest commit on main: https://github.com/r-lib/styler/blob/208d9c7abb4eb44436695a68a19ea979c99ce921/.github/workflows/touchstone-comment.yaml#L20

However, I still see the ballot_box_with_check.. but the PR #127 changed that so I am confused. Do we need to release a new tag?

@assignUser
Copy link
Collaborator

assignUser commented Mar 29, 2024

In this repo the emojis show up fine: kgoldfeld/simstudy#221 (comment)
So it seems to be a styler specific problem which I don't understand... actually simstudy uses an old version of the workflow where the /actions/receive is inlined. We need to update the v1 tag to point to HEAD of main.

@assignUser
Copy link
Collaborator

https://github.com/lorenzwalthert/touchstone/blob/main/actions/receive/action.yaml#L103

Sorry, I didn't think of that when we merged the fixes.

@lorenzwalthert
Copy link
Owner

Ok, so should we create a new tag and move the default? I guess no one would want to use @v1 anymore and there are no breaking changes. Should we release @v1.0.1 (as SemVer would suggest)? or what's the preferred versioning scheme with GitHub Actions?

@assignUser
Copy link
Collaborator

Usually for actions you would tag @v1.0.1 and additionally move the v1 tag to head

@lorenzwalthert
Copy link
Owner

Great. Can you do that?

@assignUser
Copy link
Collaborator

Done, that should propagate the fix to styler!

@lorenzwalthert
Copy link
Owner

It has, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants