update emojis #127
update emojis #127
Conversation
|
@sbfnk can you please also update the snapshots of the tests to make the unit tests pass? |
| no_change <- " :ballot_box_with_check:" | ||
| no_change <- ":heavy_check_mark:" |
There was a problem hiding this comment.
nit: Why the switch from ☑️ to ✔️? Aesthetic preference or is there a readability advantage or something like that?
There was a problem hiding this comment.
Purely aesthetic - not sure why but on (my) Chromium this gets rendered to a small thin rather than heavy checkmark:
But I don't feel strongly - happy to revert in fact.
There was a problem hiding this comment.
Ah I don't mind it. I might even prefer it? I was mainly asking because there is sometimes stuff that's better for not obvious but important reasons like screen-reader friendliness or something :)
My version ^^:
|
I approved the changes, I think you could have merged yourself. I tend to let contributors merge their own PR. |
Closes #126