Isolated checkbox fixed issue #51 #183
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlosPovedaC
changed the title
|
Hi thanks for your PR! Can you shortly tell me why you think that the master branch is broken? |
lostdesign
requested changes
Oct 8, 2022
src/components/editor.vue
Outdated
| @@ -123,7 +123,9 @@ export default { | |||
| content: this.getContent, | |||
| autofocus: true, | |||
| onUpdate: ({ editor }) => { | |||
| this.setContent(editor.getHTML()) | |||
| var aux = editor.getHTML(); | |||
There was a problem hiding this comment.
Could you please use const and rename the variable to data?
lostdesign
requested changes
Oct 8, 2022
Final fixWe solved the issue in the master branch, we already fixed the bug that blocks the popup after writing the slash command on the editor PR: #185 IMPORTANT: PR #185 fixing slash command must be merged before to see this funcionality working on new installations Video with the issue solved: Grabacion.de.pantalla.2022-10-09.a.las.13.23.01.mov |
lostdesign
requested changes
Oct 9, 2022
| @@ -123,7 +123,9 @@ export default { | |||
| content: this.getContent, | |||
| autofocus: true, | |||
| onUpdate: ({ editor }) => { | |||
| this.setContent(editor.getHTML()) | |||
| const data = editor.getHTML(); | |||
| this.editor.commands.clearContent() | |||
There was a problem hiding this comment.
Using the keyboard rather than the mouse breaks the slash command panel close.
|
Any news on this? |
|
Hey, I'd close this PR. Please open a new PR once you continue on this. Thanks in advance :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We solved the problem about the isolated Checkboxes #51 between the week days, as you can see in the following videos.
Before solving the problem:
Grabacion.de.pantalla.2022-10-08.a.las.15.24.12.mov
After solving the problem:
Grabacion.de.pantalla.2022-10-08.a.las.15.26.16.mov
Bugfix description:
We assing the getEditor() value into a new variable (aux) and then we clear the editor before assigning. After that the editor object was set it with the new variable value (aux). Doing this the Checkboxes between week days this are perfectly isolated.