Skip to content
This repository has been archived by the owner on Sep 4, 2022. It is now read-only.

Add ESLint and prettier #130

Merged
merged 6 commits into from
Oct 2, 2019
Merged

Add ESLint and prettier #130

merged 6 commits into from
Oct 2, 2019

Conversation

S3B4S
Copy link
Collaborator

@S3B4S S3B4S commented Oct 1, 2019

Issue: #124

I've used the following reference to set it up: https://nuxtjs.org/guide/development-tools/#eslint-and-prettier.

Highlighted rules:

  • No semicolons
  • 2 spaces
  • Single quotes
  • Trailing comma for multi-line objects / arrays
  • Prop validation required (default value for prop isn't)

To run ESLint: npm run lint.
To fix some that are doable: npm run lintfix.

I've also enabled this to be run while hot reloading. But it's not yet set up to be run before commiting (git hook).

This PR also fixes any errors and warnings that have occured by adding the ESLint.

@S3B4S S3B4S changed the base branch from master to dev October 1, 2019 12:44
@wo1028183705
Copy link

@lostdesign lostdesign merged commit fdd663c into dev Oct 2, 2019
@lostdesign lostdesign deleted the features/prettier branch October 2, 2019 08:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants