Always dup url_prefix in Connection#build_exclusive_url (#1288)

lostisland · Jun 24, 2021 · 4dd3689 · 4dd3689
1 parent 830b696
commit 4dd3689
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/lib/faraday/connection.rb b/lib/faraday/connection.rb
@@ -520,9 +520,8 @@ def build_request(method)
     # @return [URI]
     def build_exclusive_url(url = nil, params = nil, params_encoder = nil)
       url = nil if url.respond_to?(:empty?) && url.empty?
-      base = url_prefix
+      base = url_prefix.dup
       if url && base.path && base.path !~ %r{/$}
-        base = base.dup
         base.path = "#{base.path}/" # ensure trailing slash
       end
       url = url && URI.parse(url.to_s).opaque ? url.to_s.gsub(':', '%3A') : url

diff --git a/spec/faraday/connection_spec.rb b/spec/faraday/connection_spec.rb
@@ -253,6 +253,13 @@
       expect(uri.path).to eq('/sake.html')
     end
 
+    it 'always returns new URI instance' do
+      conn.url_prefix = 'http://sushi.com'
+      uri1 = conn.build_exclusive_url(nil)
+      uri2 = conn.build_exclusive_url(nil)
+      expect(uri1).not_to equal(uri2)
+    end
+
     context 'with url_prefixed connection' do
       let(:url) { 'http://sushi.com/sushi/' }