Skip to content

Commit

Permalink
Fix Code Review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
iMacTia committed Aug 14, 2021
1 parent 64b1c0b commit 7de5dc8
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion docs/middleware/request/authentication.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ These can be added as middleware manually or through the helper methods.

### Basic Authentication

`TokenAuthentication` adds a 'Basic' type Authorization header to a Faraday request.
`BasicAuthentication` adds a 'Basic' type Authorization header to a Faraday request.

```ruby
Faraday.new(...) do |conn|
Expand Down
6 changes: 3 additions & 3 deletions lib/faraday/connection.rb
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@ def basic_auth(login, pass)
warn <<~TEXT
WARNING: `Faraday::Connection#basic_auth` is deprecated; it will be removed in version 2.0.
While initializing your connection, use `#request(:basic_auth, ...)` instead.
See https://lostisland.github.io/faraday/middleware/authentication or more usage info.
See https://lostisland.github.io/faraday/middleware/authentication for more usage info.
TEXT
set_authorization_header(:basic_auth, login, pass)
end
Expand All @@ -322,7 +322,7 @@ def token_auth(token, options = nil)
warn <<~TEXT
WARNING: `Faraday::Connection#token_auth` is deprecated; it will be removed in version 2.0.
While initializing your connection, use `#request(:token_auth, ...)` instead.
See https://lostisland.github.io/faraday/middleware/authentication or more usage info.
See https://lostisland.github.io/faraday/middleware/authentication for more usage info.
TEXT
set_authorization_header(:token_auth, token, options)
end
Expand All @@ -349,7 +349,7 @@ def authorization(type, token)
warn <<~TEXT
WARNING: `Faraday::Connection#authorization` is deprecated; it will be removed in version 2.0.
While initializing your connection, use `#request(:authorization, ...)` instead.
See https://lostisland.github.io/faraday/middleware/authentication or more usage info.
See https://lostisland.github.io/faraday/middleware/authentication for more usage info.
TEXT
set_authorization_header(:authorization, type, token)
end
Expand Down

0 comments on commit 7de5dc8

Please sign in to comment.