Skip to content

Commit

Permalink
Add base64 to runtime dependency
Browse files Browse the repository at this point in the history
This PR add `base64` to runtime dependency to suppress the following Ruby 3.3's warning:

```console
$ ruby -ve 'require "faraday"'
ruby 3.3.0dev (2023-08-14T15:48:39Z master 52837fcec2) [x86_64-darwin22]
/Users/koic/.rbenv/versions/3.3.0-dev/lib/ruby/gems/3.3.0+0/gems/faraday-2.7.10/lib/faraday/utils.rb:3:
warning: base64 which will be not part of the default gems since Ruby 3.4.0
```

cf: rails/rails#48907
  • Loading branch information
koic authored and olleolleolle committed Aug 15, 2023
1 parent 230fa1b commit ea30bd0
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions faraday.gemspec
Expand Up @@ -15,6 +15,7 @@ Gem::Specification.new do |spec|

spec.required_ruby_version = '>= 2.6'

spec.add_dependency 'base64'
# faraday-net_http is the "default adapter", but being a Faraday dependency it can't
# control which version of faraday it will be pulled from.
# To avoid releasing a major version every time there's a new Faraday API, we should
Expand Down

0 comments on commit ea30bd0

Please sign in to comment.