Do not percent-encode tilde

[hakanensari]

Faraday::Utils.escape is currently forwarding to CGI.escape, which percent-encodes tilde.

Quoting RFC 3986,

For consistency, percent-encoded octets in the ranges of ALPHA
(%41-%5A and %61-%7A), DIGIT (%30-%39), hyphen (%2D), period (%2E),
underscore (%5F), or tilde (%7E) should not be created by URI
producers and, when found in a URI, should be decoded to their
corresponding unreserved characters by URI normalizers.

It would be awesome to use the percent-encoding method in Addressable::URI or if there's an issue with that, at least replace the current method with:

def escape(component)
  component.to_s.gsub(/([^\w.~-]+)/) do
     '%' + $1.unpack('H2' * $1.bytesize).join('%').upcase
  end
end

In case you wonder why I care about this: CGI.escape is messing with Amazon Web Services signatures.

I'd personally throw in Addressable, but I understand there's some ongoing issue with it?

[technoweenie]

I don't want to depend on another lib if possible (though, having
Faraday work great with Addressable is very important). A fix to
Faraday.escape would be preferable.

[ezkl]

Current test suite passes w/ only slight modification to @hakanensari's proposed escape method.

[hakanensari]

+1